[Draft] Add Web API for MarkItDown #202
Conversation
Related to microsoft#133
|
In Testing |
vs4vijay
changed the title
|
Thank you very much, we need api interface access in order to utilize automated processes, we are very optimistic about this project, thanks again to the great developers. |
|
I deployed a simple REST API, ya'll can try it out. Here are the specs: |
| @@ -12,12 +12,12 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| ffmpeg \ | |||
| && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| RUN pip install markitdown | |||
| RUN pip install markitdown fastapi uvicorn | |||
There was a problem hiding this comment.
| RUN pip install markitdown fastapi uvicorn | |
| RUN pip install markitdown fastapi uvicorn python-multipart |
Without python-multipart the API won't start.
It's still weird that markitdown is being installed here. This means if the source gets changed and you want to check if the Docker image works you first need to publish the package to pip... It would be better if the current src folder would be included here.
|
|
||
| # Default USERID and GROUPID | ||
| ARG USERID=10000 | ||
| ARG GROUPID=10000 | ||
|
|
||
| USER $USERID:$GROUPID | ||
|
|
||
| ENTRYPOINT [ "markitdown" ] | ||
| ENTRYPOINT ["uvicorn", "src.markitdown.api:app", "--host", "0.0.0.0", "--port", "8000"] |
There was a problem hiding this comment.
This doesn't work: src/markitdown/api.py doesn't exists, so the API will not start.
You must copy the src directory:
| ENTRYPOINT ["uvicorn", "src.markitdown.api:app", "--host", "0.0.0.0", "--port", "8000"] | |
| COPY src /src | |
| ENTRYPOINT ["uvicorn", "src.markitdown.api:app", "--host", "0.0.0.0", "--port", "8000"] |
Note that in .dockerignore that everything is ignored, so the COPY won't work.
Modify the .dockerignore so the src/-folder gets included:
*
!/src
Related to #133